sql: convert NULL to false#3544
Merged
madelynnblue merged 1 commit intocockroachdb:masterfrom Dec 30, 2015
madelynnblue:sql-null-false
Merged
sql: convert NULL to false#3544madelynnblue merged 1 commit intocockroachdb:masterfrom madelynnblue:sql-null-false
madelynnblue merged 1 commit intocockroachdb:masterfrom
madelynnblue:sql-null-false
Conversation
7 tasks
sql/parser/datum.go
Outdated
Contributor
There was a problem hiding this comment.
compare directly to DNull and add a simple test
Collaborator
|
This PR needs an associated test. |
Matches behavior of postgres, which returns 2 for: select case when null then 1 else 2 end; Where previously we would exit with: query error: cannot convert NULL to bool
Contributor
Author
|
Test added. Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion. sql/parser/datum.go, line 91 [r1] (raw file): Comments from the review on Reviewable.io |
Collaborator
|
LGTM |
madelynnblue
added a commit
that referenced
this pull request
Dec 30, 2015
sql: convert NULL to false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches behavior of postgres, which returns 2 for:
select case when null then 1 else 2 end;
Where previously we would exit with:
query error: cannot convert NULL to bool