storage/engine: fix Go 1.12 build due to missing C.bool type casts#35195
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 26, 2019
Merged
storage/engine: fix Go 1.12 build due to missing C.bool type casts#35195craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Before this, compiling with Go 1.12 would fail with an error like: ``` cannot use _cgo1 (type bool) as type _Ctype__Bool in argument to _Cfunc_DBIterPrev ``` I haven't looked into what changed to break this yet. Release note: None
Member
|
This change is |
tbg
approved these changes
Feb 26, 2019
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Feb 26, 2019
35195: storage/engine: fix Go 1.12 build due to missing C.bool type casts r=nvanbenschoten a=nvanbenschoten Before this, compiling with Go 1.12 would fail with an error like: ``` cannot use _cgo1 (type bool) as type _Ctype__Bool in argument to _Cfunc_DBIterPrev ``` I haven't looked into what changed to break this yet. Release note: None Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Contributor
Build succeeded |
Member
|
I am backporting this to 2.1 (the "verify source archive" part of the build is failing with the same error). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this, compiling with Go 1.12 would fail with an error like:
I haven't looked into what changed to break this yet.
Release note: None