storage: fix NPE while printing trivial truncateDecision#34399
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 30, 2019
Merged
storage: fix NPE while printing trivial truncateDecision#34399craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Fixes cockroachdb#34398. Release note: None
Member
|
This change is |
This was referenced Jan 30, 2019
bdarnell
approved these changes
Jan 30, 2019
Member
Author
|
bors r=bdarnell TFTR! |
craig bot
pushed a commit
that referenced
this pull request
Jan 30, 2019
33474: docs: add RFC to expose follower reads to clients r=ajwerner a=ajwerner Relates to #16593. Release note: None 34399: storage: fix NPE while printing trivial truncateDecision r=bdarnell a=tbg Fixes #34398. Release note: None Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com> Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
andreimatei
reviewed
Jan 30, 2019
Contributor
andreimatei
left a comment
There was a problem hiding this comment.
is this the last failure (node death) in #34159 (comment) ?
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @petermattis)
Member
Author
|
Probably, you should take a look (I can't pull these artifacts where I am). |
Contributor
Build succeeded |
This was referenced Jan 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34398.
Release note: None