Revert "Revert "engineccl: ignore intents beneath start in MVCCIncrem…#33534
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 7, 2019
Merged
Revert "Revert "engineccl: ignore intents beneath start in MVCCIncrem…#33534craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
…entalIterator"" This reverts commit ceb4072. Release note: None
Member
|
This change is |
bdarnell
approved these changes
Jan 7, 2019
Member
|
LGTM |
Contributor
Author
|
bors r=bdarnell,tbg The test failure is a leaked goroutine that looks spurious and unrelated to this change. |
craig bot
pushed a commit
that referenced
this pull request
Jan 7, 2019
33534: Revert "Revert "engineccl: ignore intents beneath start in MVCCIncrem… r=bdarnell,tbg a=benesch …entalIterator"" This reverts commit ceb4072. This previously caused flakiness in some CDC tests, but that's been fixed by #32487. Release note: None Co-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…entalIterator""
This reverts commit ceb4072. This previously caused flakiness in some CDC tests, but that's been fixed by #32487.
Release note: None