Conversation
There was a problem hiding this comment.
You can't merge this if the test is failing. I'd change this to expect the error that is occurring and add a TODO comment to fix.
There was a problem hiding this comment.
I wasn't planning on merging this; this branch is on the main repo so that someone (or I) can replace my commit with one that contains a fix.
|
This can also be triggered by: |
|
That error might be a red herring, since it is also produced by: |
|
There is also: Where it successfully returns a result when a bogus table is specified. Edit: the table |
|
I don't understand how it could be a red herring. |
|
Assigning to @petermattis because I couldn't figure this out (and neither could @mjibson). |
|
Ok, I'll take a look. |
8c78708 to
ff4fc96
Compare
|
LGTM. You can |
ff4fc96 to
b613356
Compare
|
LGTM Review status: 0 of 6 files reviewed at latest revision, 4 unresolved discussions. sql/parser/eval.go, line 878 [r2] (raw file): sql/parser/eval.go, line 1081 [r2] (raw file): sql/subquery.go, line 73 [r2] (raw file): Comments from the review on Reviewable.io |
|
Good grief, I swear my grammar is better than what I demonstrated in this PR. Review status: 0 of 6 files reviewed at latest revision, 4 unresolved discussions. Comments from the review on Reviewable.io |
b613356 to
75fe987
Compare
sql: implement EXISTS expressions
Reduced version of #3288. Fails with:
Note this branch is on the main repo, not my fork (so you can push commits to it).