ccl: skip TestChangefeedSchemaChangeNoBackfill due to flakiness#32461
Closed
tbg wants to merge 1 commit intocockroachdb:masterfrom
Closed
ccl: skip TestChangefeedSchemaChangeNoBackfill due to flakiness#32461tbg wants to merge 1 commit intocockroachdb:masterfrom
tbg wants to merge 1 commit intocockroachdb:masterfrom
Conversation
See cockroachdb#32433. Release note: None
Member
|
This change is |
petermattis
approved these changes
Nov 19, 2018
Member
Author
|
bors r=petermattis |
craig bot
pushed a commit
that referenced
this pull request
Nov 19, 2018
32461: ccl: skip TestChangefeedSchemaChangeNoBackfill due to flakiness r=petermattis a=tbg See #32433. Release note: None 32462: storage: fix error message in TestStoreRangeRemoveDead r=petermattis a=tbg It was printing a pointer where the observer would expect an integer. Release note: None Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Contributor
Build failed (retrying...) |
Member
Author
|
bors r- |
Contributor
Canceled |
Member
Author
|
This problem was introduced or exposed in #32421 and affects multiple tests (I think most of the CDC ones), so skipping stuff is just a whack-a-mole. |
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Nov 19, 2018
…rator" This reverts commit 765df40. Unfortunately, cockroachdb#32421 has turned > make test TESTS=TestChangefeedSchemaChangeNoBackfill PKG=github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl TESTTIMEOUT=30s TESTFLAGS=-v and various other tests into failing propositions (they take forever). This slows down the CDC pipeline and the symptoms affect various other CDC tests so that skipping the test isn't an attractive option. Besides, this was clearly not intended, so there's probably something wrong with the code being reverted here. We should investigate and submit a fix. Closes cockroachdb#32461. Fixes cockroachdb#32433. Fixes cockroachdb#32444. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Nov 19, 2018
32465: Revert "engineccl: ignore intents beneath start in MVCCIncrementalIterator" r=benesch a=tbg This reverts commit 765df40. Unfortunately, #32421 has turned > make test TESTS=TestChangefeedSchemaChangeNoBackfill PKG=github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl TESTTIMEOUT=30s TESTFLAGS=-v and various other tests into failing propositions (they take forever). This slows down the CDC pipeline and the symptoms affect various other CDC tests so that skipping the test isn't an attractive option. Besides, this was clearly not intended, so there's probably something wrong with the code being reverted here. We should investigate and submit a fix. Closes #32461. Fixes #32433. Fixes #32444. Release note: None Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #32433.
Release note: None