storage/engine: wrap long lines in tests#32395
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 28, 2018
Merged
Conversation
Member
|
This change is |
petermattis
approved these changes
Nov 15, 2018
Collaborator
petermattis
left a comment
There was a problem hiding this comment.
Reviewed 20 of 20 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
Contributor
Author
|
Flaked on Examples ORMs. Thanks for the lightening review! bors r=petermattis |
Contributor
Author
|
bors r- |
Contributor
Canceled |
Contributor
Author
|
D'oh, need to rebase. |
Contributor
Author
|
bors r=petermattis |
Contributor
|
👎 Rejected by PR status |
Contributor
Author
|
Erm. bors r=petermattis |
Contributor
|
👎 Rejected by PR status |
The tests in this package were a case study in how to wrap code for maximum illegibility. Enforce a line limit of 100 characters, except where exceeding the limit by a few characters makes the code substantially more readable. The primary tool employed is extracting calls to context.Background() into a per-test ctx variable. All changes in this patch are straightforward reformattings with no behavior changes. Release note: None
Contributor
Author
|
😞 bors r=petermattis |
craig bot
pushed a commit
that referenced
this pull request
Nov 28, 2018
32395: storage/engine: wrap long lines in tests r=petermattis a=benesch Ignore the first commit, which is landing now in #32389. This isn't a high-priority cleanup, but it's been driving me nuts and I was in the area. --- The tests in this package were a case study in how to wrap code for maximum illegibility. Enforce a line limit of 100 characters, except where exceeding the limit by a few characters makes the code substantially more readable. The primary tool employed is extracting calls to context.Background() into a per-test ctx variable. All changes in this patch are straightforward reformattings with no behavior changes. Release note: None Co-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore the first commit, which is landing now in #32389.
This isn't a high-priority cleanup, but it's been driving me nuts and I was in the area.
The tests in this package were a case study in how to wrap code for
maximum illegibility. Enforce a line limit of 100 characters, except
where exceeding the limit by a few characters makes the code
substantially more readable.
The primary tool employed is extracting calls to context.Background()
into a per-test ctx variable.
All changes in this patch are straightforward reformattings with no
behavior changes.
Release note: None