Get batch arg, when looking for EndTransaction, just look at the last entry#3192
Closed
veteranlu wants to merge 1 commit intocockroachdb:masterfrom
Closed
Get batch arg, when looking for EndTransaction, just look at the last entry#3192veteranlu wants to merge 1 commit intocockroachdb:masterfrom
veteranlu wants to merge 1 commit intocockroachdb:masterfrom
Conversation
0c9e102 to
f84231f
Compare
roachpb/batch.go
Outdated
Member
There was a problem hiding this comment.
comment needs an update since it'll look for the "last" EndTransaction (there should only ever be at most one and if so at that position, but still).
Contributor
Author
|
@tamird u r right, I add some test case to make sure the correct logic. |
Member
There was a problem hiding this comment.
GetArg returns a request of the given type if one is contained in the Batch..
Member
|
Some minor comments but then LGTM. Sorry we let this sit for a couple of days. |
tbg
added a commit
that referenced
this pull request
Dec 14, 2015
cleanup #3192: small tweak for batch.GetArg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just finished @tschottdorf 's TODO, simple logic, therefore, don't add any test case.