cdc: Re-enable Fingerprint Validator#31774
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 25, 2018
Merged
Conversation
Member
|
This change is |
Contributor
Author
danhhz
reviewed
Oct 24, 2018
Contributor
danhhz
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
73164a9 to
78a7d75
Compare
Fingerprint validator was previously disabled due to its lack of support for "initial scan" situations. This commit fixes fingerprint validator to support initial scans correctly and re-enables the validator in tests that were using it. Resolves cockroachdb#31110 Release note: None
78a7d75 to
a3eaebf
Compare
Contributor
Author
|
bors r=danhhz |
craig bot
pushed a commit
that referenced
this pull request
Oct 25, 2018
31774: cdc: Re-enable Fingerprint Validator r=danhhz a=mrtracy Fingerprint validator was previously disabled due to its lack of support for "initial scan" situations. This commit fixes fingerprint validator to support initial scans correctly and re-enables the validator in tests that were using it. Resolves #31110 Release note: None Co-authored-by: Matt Tracy <matt@cockroachlabs.com>
Contributor
Build succeeded |
mrtracy
pushed a commit
to mrtracy/cockroach
that referenced
this pull request
Oct 25, 2018
Fix a bug introduced by cockroachdb#31774; the test was creating a fingerprint validator which requires a table name, but in this case needed the fully qualified name with the database (`bank.bank` instead of `bank`). Also fixed a nil reference that occurred when exiting the test early from the command line. Resolves cockroachdb#31903 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Oct 29, 2018
31905: cdc: Fix cdc/bank roachtest r=danhhz a=mrtracy Fix a bug introduced by #31774; the test was creating a fingerprint validator which requires a table name, but in this case needed the fully qualified name with the database (`bank.bank` instead of `bank`). Also fixed a nil reference that occurred when exiting the test early from the command line. Resolves #31903 Release note: None Co-authored-by: Matt Tracy <matt@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fingerprint validator was previously disabled due to its lack of support
for "initial scan" situations. This commit fixes fingerprint validator
to support initial scans correctly and re-enables the validator in
tests that were using it.
Resolves #31110
Release note: None