backport-2.1: sql: fix two bugs with TRUNCATE#29262
Merged
craig[bot] merged 3 commits intocockroachdb:release-2.1from Aug 29, 2018
Merged
backport-2.1: sql: fix two bugs with TRUNCATE#29262craig[bot] merged 3 commits intocockroachdb:release-2.1from
craig[bot] merged 3 commits intocockroachdb:release-2.1from
Conversation
related to cockroachdb#27687 Release note (sql change): fixes table descriptor corruption when TRUNCATE TABLE is run while DROP COLUMN is being processed.
Release note: None
The job is modified in the same transaction as the user's DROP/TRUNCATE transaction. Release note (sql change): Fixes problem where when a DROP/TRUNCATE is run while a schema change like CREATE INDEX is running, the corresponding job would stay running indefinitely.
Member
|
This change is |
knz
approved these changes
Aug 29, 2018
Contributor
knz
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 6 of 6 files at r2, 4 of 4 files at r3.
Reviewable status:complete! 0 of 0 LGTMs obtained
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 29, 2018
29262: backport-2.1: sql: fix two bugs with TRUNCATE r=vivekmenezes a=vivekmenezes Backport 3/3 commits from #28721. /cc @cockroachdb/release --- sql: correctly resolve schema mutations during TRUNCATE related to #27687 sql: mark schema change job as successful when table DROP/TRUNCATE The job is modified in the same transaction as the user's DROP/TRUNCATE transaction. Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 3/3 commits from #28721.
/cc @cockroachdb/release
sql: correctly resolve schema mutations during TRUNCATE
related to #27687
sql: mark schema change job as successful when table DROP/TRUNCATE
The job is modified in the same transaction as the user's DROP/TRUNCATE transaction.