sql/testutils: avoid generating array-of-array datums#28960
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 22, 2018
Merged
sql/testutils: avoid generating array-of-array datums#28960craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Release note: None
Member
|
This change is |
justinj
reviewed
Aug 22, 2018
Contributor
justinj
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
Contributor
Author
|
thank you! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 22, 2018
28937: sql: remove dead code r=knz a=knz The functions to retrieve the sizes of value encodings have not been used in a long time. Remove them. Release note: None 28960: sql/testutils: avoid generating array-of-array datums r=knz a=knz Found while working on #28690. Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while working on #28690.