sql/parser: parsing ROW produces *Tuple, not Tuple#28192
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 2, 2018
Merged
sql/parser: parsing ROW produces *Tuple, not Tuple#28192craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
The tree.Tuple result of parsing tuples was immediately re-allocated on the heap in the parent action rule. This patch simplifies this by allocating on the heap upfront. Release note: None
Member
|
This change is |
Contributor
|
Lgtm |
Contributor
Author
|
Thanks bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 2, 2018
28192: sql/parser: parsing ROW produces *Tuple, not Tuple r=knz a=knz Forked off from #28143. Needed for #26624. The tree.Tuple result of parsing tuples was immediately re-allocated on the heap in the parent action rule. This patch simplifies this by allocating on the heap upfront. Release note: None Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forked off from #28143.
Needed for #26624.
The tree.Tuple result of parsing tuples was immediately re-allocated
on the heap in the parent action rule. This patch simplifies this by
allocating on the heap upfront.
Release note: None