sql: support casting arrays and tuples to strings#28183
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 3, 2018
Merged
sql: support casting arrays and tuples to strings#28183craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
The previous patch to fix pgwire text encoding for tuples/arrays really defines a different conversion algorithm from array/tuples to strings. This incidentally is the general-purpose algorithm used in PostgreSQL to convert arrays and tuples to strings, not just for pgwire. This patch utilizes this observation to define the new (and now correct) casts from array and tuple types to strings based on the new algorithm, like PostgreSQL does. Release note (sql change): CockroachDB now supports converting arrays and tuples to strings for compatibility with PostgreSQL.
f068bbe to
ada0e4d
Compare
Contributor
Author
|
rebased, RFAL |
BramGruneir
approved these changes
Aug 3, 2018
Member
BramGruneir
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale)
Contributor
Author
|
thanks! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 3, 2018
28183: sql: support casting arrays and tuples to strings r=knz a=knz Fixes #24746. Forked off #28143. The previous patch to fix pgwire text encoding for tuples/arrays really defines a different conversion algorithm from array/tuples to strings. This incidentally is the general-purpose algorithm used in PostgreSQL to convert arrays and tuples to strings, not just for pgwire. This patch utilizes this observation to define the new (and now correct) casts from array and tuple types to strings based on the new algorithm, like PostgreSQL does. Release note (sql change): CockroachDB now supports converting arrays and tuples to strings for compatibility with PostgreSQL. Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24746.
Forked off #28143.
The previous patch to fix pgwire text encoding for tuples/arrays
really defines a different conversion algorithm from array/tuples to
strings.
This incidentally is the general-purpose algorithm used in PostgreSQL
to convert arrays and tuples to strings, not just for pgwire.
This patch utilizes this observation to define the new
(and now correct) casts from array and tuple types to strings
based on the new algorithm, like PostgreSQL does.
Release note (sql change): CockroachDB now supports converting arrays
and tuples to strings for compatibility with PostgreSQL.