libroach: rotate data encryption keys while running.#28148
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 1, 2018
Merged
libroach: rotate data encryption keys while running.#28148craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
29 tasks
bdarnell
approved these changes
Aug 1, 2018
Contributor
bdarnell
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 4 of 4 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained
* use shared_ptr for keys in key manager * keep active date key as member * regenerate data key if needed when asked for Release note (enterprise change): rotate encryption keys while running
b25c6e6 to
7d98456
Compare
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 1, 2018
28148: libroach: rotate data encryption keys while running. r=mberhault a=mberhault More details in the separate commits: - keep the active data key as its own member so we don't have to look it up all the time, and make `Get(Current)Key` return `shared_ptr` - actual rotation Co-authored-by: marc <marc@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note (enterprise change): rotate encryption keys while running