sql: casting to timestamp should strip tz info#28128
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 1, 2018
Merged
sql: casting to timestamp should strip tz info#28128craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
knz
reviewed
Aug 1, 2018
| fn: func(ctx *EvalContext, left Datum, right Datum) (Datum, error) { | ||
| // These two quantities aren't directly comparable. Convert the | ||
| // TimestampTZ to a timestamp first. | ||
| nanos := left.(*DTimestamp).Sub(right.(*DTimestampTZ).stripTimeZone(ctx).Time).Nanoseconds() |
Contributor
There was a problem hiding this comment.
please add tests in eval_test.go for these comparison function changes.
f5ce367 to
9464669
Compare
Member
Author
|
Done, PTAL |
knz
approved these changes
Aug 1, 2018
Contributor
knz
left a comment
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, 2 of 2 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale)
pkg/sql/sem/tree/datum.go, line 2091 at r2 (raw file):
_, locOffset := d.Time.In(ctx.GetLocation()).Zone() newTime := duration.Add(d.Time.UTC(), duration.FromInt64(int64(locOffset))) fmt.Println("Stripping", d, locOffset, newTime)
please remove the fmt.Println here
Member
Author
|
Oops, thanks for catching |
And binary operations between timestamp and timestamptz should strip the tz from the timestamptz. Confirmed that all of this behavior matches postgres (and that it didn't before). Release note (bug fix): correct casts and binary operators between timestamptz and timestamp in some cases.
9464669 to
9583b06
Compare
Member
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 1, 2018
28128: sql: casting to timestamp should strip tz info r=jordanlewis a=jordanlewis And binary operations between timestamp and timestamptz should strip the tz from the timestamptz. Confirmed that all of this behavior matches postgres (and that it didn't before). Release note (bug fix): correct casts and binary operators between timestamptz and timestamp in some cases. 28149: sql: avoid using Tuple in RangePartition r=knz a=knz Forked off #28143, needed for #25522 / #26624. The `Tuple` AST node is really for scalar tuples. RangePartition is not using a scalar tuple. So split them. Release note: None Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com> Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And binary operations between timestamp and timestamptz should strip the
tz from the timestamptz.
Confirmed that all of this behavior matches postgres (and that it didn't
before).
Release note (bug fix): correct casts and binary operators between
timestamptz and timestamp in some cases.