kv: get rid of test FUD#28117
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 1, 2018
Merged
Conversation
Some TCS tests were employing a teardownHeartbeat() method. That's not needed - all the test indirectly stop a stopper that also tears down dangling heartbeat loops. Release note: None
Member
|
This change is |
benesch
approved these changes
Jul 31, 2018
andreimatei
commented
Aug 1, 2018
Contributor
Author
andreimatei
left a comment
There was a problem hiding this comment.
bors r+
Reviewable status:
complete! 0 of 0 LGTMs obtained
craig bot
pushed a commit
that referenced
this pull request
Aug 1, 2018
28117: kv: get rid of test FUD r=andreimatei a=andreimatei Some TCS tests were employing a teardownHeartbeat() method. That's not needed - all the test indirectly stop a stopper that also tears down dangling heartbeat loops. Release note: None 28124: client: delete stale comment r=andreimatei a=andreimatei There used to be a discrepancy between deadline exceeded errors detected on the server side and those detected on the client side for elided EndTransaction requests. No longer since #21140. Release note: None Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some TCS tests were employing a teardownHeartbeat() method. That's not
needed - all the test indirectly stop a stopper that also tears down
dangling heartbeat loops.
Release note: None