Implement replica tombstones.#2798
Merged
bdarnell merged 2 commits intocockroachdb:masterfrom Oct 11, 2015
Merged
Conversation
multiraft/multiraft.go
Outdated
Contributor
There was a problem hiding this comment.
I assume you care about the 0 value. How about creating a const invalidReplicaID = 0
Contributor
Author
There was a problem hiding this comment.
Done, but the constant needs to be exported for use from Store.GroupStorage, and changed the value from 0 to -1.
Member
|
LGTM mod vivek's comments. |
multiraft/multiraft.go
Outdated
Contributor
There was a problem hiding this comment.
a bit misleading since the thing that follows the colon is the error not the incoming message.
Contributor
Author
There was a problem hiding this comment.
Added parens around the new phrase to clarify.
Contributor
|
LGTM |
When a replica is removed, leave a tombstone behind, and prevent the recreation of the same range without a higher replica ID. Added a new test which demonstrates a split-brain scenario caused by the reuse of old replica IDs. Also fixes some other tests, but not all of the ones that it has been blamed for. Fixes cockroachdb#768.
3bfa9f5 to
eb84a06
Compare
bdarnell
added a commit
that referenced
this pull request
Oct 11, 2015
Implement replica tombstones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a replica is removed, leave a tombstone behind, and prevent the
recreation of the same range without a higher replica ID.
Added a new test which demonstrates a split-brain scenario caused by
the reuse of old replica IDs. Also fixes some other tests, but
not all of the ones that it has been blamed for.
Fixes #768.