libroach: Log encryption actions#27880
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 24, 2018
Merged
Conversation
Use a logger with verbosity `V(0)` to log encryption key actions. The main logger passed to rocksdb remains at `V(3)`. This gives some visibility in the logs about the state of encryption. small changes: - rename registry `active_(store|data)_key` to `active_(store|data)_key_id` for clarity - log AESNI and "core dump" warnings to `V(0)` log Release note (enterprise change): log some encryption status.
Member
|
This change is |
29 tasks
bdarnell
approved these changes
Jul 24, 2018
Contributor
bdarnell
left a comment
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
Contributor
Author
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 24, 2018
27880: libroach: Log encryption actions r=mberhault a=mberhault Use a logger with verbosity `V(0)` to log encryption key actions. The main logger passed to rocksdb remains at `V(3)`. This gives some visibility in the logs about the state of encryption. small changes: - rename registry `active_(store|data)_key` to `active_(store|data)_key_id` for clarity - log AESNI and "core dump" warnings to `V(0)` log Release note (enterprise change): log some encryption status. Co-authored-by: marc <marc@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a logger with verbosity
V(0)to log encryption key actions. The main logger passed to rocksdb remains atV(3).This gives some visibility in the logs about the state of encryption.
small changes:
active_(store|data)_keytoactive_(store|data)_key_idfor clarityV(0)logRelease note (enterprise change): log some encryption status.