libroach: more accurate encryption file statistics.#27388
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 12, 2018
Merged
libroach: more accurate encryption file statistics.#27388craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
29 tasks
fef37a9 to
f558e11
Compare
bdarnell
approved these changes
Jul 11, 2018
Contributor
bdarnell
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 5 of 5 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained
Address TODOs from cockroachdb#26802 for more accurate file count/size calculation. Specifically: - plaintext files now have an entry in the file_registry - traverse file_registry when counting files - disable rocksdb deletions during the scan Still some TODOs to improve usability (eg: report "unknown" files, logic for older versions of files that stick around) but this should already drastically improve file stats reporting. Release note: None
f558e11 to
e1a2f2a
Compare
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 12, 2018
27388: libroach: more accurate encryption file statistics. r=mberhault a=mberhault Address TODOs from #26802 for more accurate file count/size calculation. Specifically: - plaintext files now have an entry in the file_registry - traverse file_registry when counting files - disable rocksdb deletions during the scan Still some TODOs to improve usability (eg: report "unknown" files, logic for older versions of files that stick around) but this should already drastically improve file stats reporting. Release note: None Co-authored-by: marc <marc@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address TODOs from #26802 for more accurate file count/size calculation.
Specifically:
Still some TODOs to improve usability (eg: report "unknown" files, logic for older versions of files that stick around) but this should already drastically improve file stats reporting.
Release note: None