opt: don't push limit through project when ordering on synthesized column#26683
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 13, 2018
Merged
Conversation
Member
|
This change is |
Contributor
|
Review status: pkg/sql/opt/norm/custom_funcs.go, line 401 at r1 (raw file):
NIT: elsewhere in the custom functions we'd abbreviate as pkg/sql/opt/norm/custom_funcs.go, line 403 at r1 (raw file):
NIT: you can use the Comments from Reviewable |
complete! 0 of 0 LGTMs obtained (and 1 stale)0d9e3d4 to
372b5d3
Compare
…lumn It is invalid to push limit/offset through a projection if the ordering depends on a synthesized column. Fix the rules to check for this. Release note: None
372b5d3 to
0a51b15
Compare
Member
Author
|
TFTR! Updated. Review status: Comments from Reviewable |
Member
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 13, 2018
26621: sql,opt: propagate composite types (labeled tuples) r=knz a=knz Needed to resolve #24866. This patch adds more complete support for composite types (labeled tuples) by ensuring the following: - tuple labels are preserved during constant folding of tuple expressions. - tuple labels are preserved during expression transformations in optimizations. - subqueries in scalar contexts receive a composite type with labels. Note that there is currently a bug in DTuple serialization which break composite literals in distributed execution, so the composite type support is not fully ready yet. This is tracked as separate bug #26624. Release note: None 26683: opt: don't push limit through project when ordering on synthesized column r=RaduBerinde a=RaduBerinde It is invalid to push limit/offset through a projection if the ordering depends on a synthesized column. Fix the rules to check for this. Release note: None Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com> Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is invalid to push limit/offset through a projection if the
ordering depends on a synthesized column. Fix the rules to check for
this.
Release note: None