sql: disable optimizer if force-lookup-joins flag set#26516
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 7, 2018
Merged
sql: disable optimizer if force-lookup-joins flag set#26516craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
The experimental flag to force lookup joins doesn't work with the optimizer (it is disabled on opt-generated plans). To allow the flag to still function for now, we disable the optimizer if the flag is set. Release note: None
Member
Contributor
|
Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
Member
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 7, 2018
26479: kv: stop the heartbeat loop on rollback errors r=andreimatei a=andreimatei A txn's heartbeat loop is generally stopped when, upon a successful request, the response's txn is no longer PENDING. This was insufficient; the loop should always be closed after an EndTransaction(commit=false), regardless of whether it results in success or error. The heartbeat loop happens to be currently closed by the context cancelation that the db.Txn() API performs, but that is going away. This fixes #26434 - TestTxnCoordSenderRetries had become flaky after #25541 because #25441 caused EndTransactions to be sent in some situations where they weren't before. What's going on in that test is that a subtest was leaking a heartbeat loop that was stopped after the subtest finished; the EndTxn sent when the loop finally was being stopped was interfering with a CommandFilter installed by a different subtest. Before #25441, the first subtest was waiting for the heartbeat loop to be done because of its own CommandFilter. However, with #25441, the first subtest's CommandFilter was being satisfied by a different, newly introduced EndTransaction. Release note: None 26516: sql: disable optimizer if force-lookup-joins flag set r=RaduBerinde a=RaduBerinde The experimental flag to force lookup joins doesn't work with the optimizer (it is disabled on opt-generated plans). To allow the flag to still function for now, we disable the optimizer if the flag is set. Release note: None Co-authored-by: Andrei Matei <andrei@cockroachlabs.com> Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The experimental flag to force lookup joins doesn't work with the
optimizer (it is disabled on opt-generated plans). To allow the flag
to still function for now, we disable the optimizer if the flag is
set.
Release note: None