cli: support encrypted stores in debug commands.#26477
cli: support encrypted stores in debug commands.#26477craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
|
I think support LDB just involves doing the same dance we're doing with the rocksdb::Options. Basically just replacing the env. It'll be a bit more annoying as we need to find and use the |
|
Review status: 0 of 4 files reviewed at latest revision, all discussions resolved, all commit checks successful. pkg/cli/debug.go, line 61 at r1 (raw file):
Why do the individual commands need to be exported? Isn't the list the only thing that's referenced from outside the package? Comments from Reviewable |
Add the `--enterprise-encryption` flag to debug commands that open rocksdb. The flag is as specified in the start command. There are a few TODOs left: * support the ldb tool somethow * add tests for this, it'll need to be interactive tests in ccl/ Release note: None
d38c902 to
5605f08
Compare
|
Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. pkg/cli/debug.go, line 61 at r1 (raw file): Previously, bdarnell (Ben Darnell) wrote…
uh. yes. nevermind. Done. Comments from Reviewable |
|
bors r+ |
26477: cli: support encrypted stores in debug commands. r=mberhault a=mberhault Add the `--enterprise-encryption` flag to debug commands that open rocksdb. The flag is as specified in the start command. There are a few TODOs left: * support the ldb tool somehow * add tests for this, it'll need to be interactive tests in ccl/ Release note: None Co-authored-by: marc <marc@cockroachlabs.com>
Build succeeded |
Add the
--enterprise-encryptionflag to debug commands that openrocksdb. The flag is as specified in the start command.
There are a few TODOs left:
Release note: None