libroach: Obey read-only option in FileRegistry and DataKeyManager.#26468
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 6, 2018
Merged
libroach: Obey read-only option in FileRegistry and DataKeyManager.#26468craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
29 tasks
These two classes handle the File and Key registries persisted to local disk. When the read-only option is set on the DB, it's important we not modify on-disk state or we risk corrupting data for a running node.
41b166b to
3c149f0
Compare
Contributor
|
Review status: 0 of 12 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 6, 2018
26468: libroach: Obey read-only option in FileRegistry and DataKeyManager. r=mberhault a=mberhault These two classes handle the File and Key registries persisted to local disk. When the read-only option is set on the DB, it's important we not modify on-disk state or we risk corrupting data for a running node. Release Note: none Co-authored-by: marc <marc@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two classes handle the File and Key registries persisted to local
disk. When the read-only option is set on the DB, it's important we not
modify on-disk state or we risk corrupting data for a running node.
Release Note: none