scripts: Remove "default" scope from gceworker#26397
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 4, 2018
Merged
scripts: Remove "default" scope from gceworker#26397craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
I don't know what the default scope is/was, but it's no longer being accepted. The "cloud-platform" scope is enough to give full permissions on the project. Release note: None
Member
|
This change is |
dt
approved these changes
Jun 4, 2018
Contributor
Author
|
From https://cloud.google.com/sdk/gcloud/reference/alpha/compute/instances/set-scopes:
The |
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 4, 2018
26397: scripts: Remove "default" scope from gceworker r=a-robinson a=a-robinson I don't know what the default scope is/was, but it's no longer being accepted. The "cloud-platform" scope is enough to give full permissions on the project. Release note: None 26402: sql: fix logic test r=arjunravinarayan a=arjunravinarayan When multiple options are specified in a logic test, the options must be comma separated, not space separated, otherwise only the first option will be picked up. Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com> Co-authored-by: Arjun Narayan <arjun@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know what the default scope is/was, but it's no longer being
accepted. The "cloud-platform" scope is enough to give full permissions
on the project.
Release note: None