opt: enable a few distsql logictests#26293
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 31, 2018
Merged
Conversation
- `distsql_indexjoin`: this is only a planning test. Modifying the split points and queries a bit to make the condition more restrictive and make the optimizer choose index joins. There was a single plan that was different, and the difference was minor (the old planner is emitting an unnecessary column). - `distsql_expr`: logic-only test, enabling for opt. - `distsql_scrub`: planning test; opt version commented out for now. Release note: None
Member
Contributor
|
Review status: 0 of 5 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
Member
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 31, 2018
25014: storage: queue requests to push txn / resolve intents on single keys r=spencerkimball a=spencerkimball
Previously, high contention on a single key would cause every thread to
push the same conflicting transaction then resolve the same intent in
parallel. This is inefficient as only one pusher needs to succeed, and
only one resolver needs to resolve the intent, and then only one writer
should proceed while the other readers/writers should in turn wait on
the previous writer by pushing its transaction. This effectively
serializes the conflicting reader/writers.
One complication is that all pushers which may have a valid, writing
transaction (i.e., `Transaction.Key != nil`), must push either the
conflicting transaction or another transaction already pushing that
transaction. This allows dependency cycles to be discovered.
Fixes #20448
25791: jobs: bump default progress log time to 30s r=mjibson a=mjibson
The previous code allowed updates to be performed every 1s, which could
cause the MVCC row to be very large causing problems with splits. We
can update much more slowly by default. In the case of a small backup
job, the 5% fraction threshold will allow a speedier update rate.
Remove a note that's not useful anymore since the referred function
can now only be used in the described safe way.
See #25770. Although this change didn't fix that bug, we still think
it's a good idea.
Release note: None
26293: opt: enable a few distsql logictests r=RaduBerinde a=RaduBerinde
- `distsql_indexjoin`: this is only a planning test. Modifying the
split points and queries a bit to make the condition more
restrictive and make the optimizer choose index joins. There was a
single plan that was different, and the difference was minor (the
old planner is emitting an unnecessary column).
- `distsql_expr`: logic-only test, enabling for opt.
- `distsql_scrub`: planning test; opt version commented out for now.
Release note: None
Co-authored-by: Spencer Kimball <spencer.kimball@gmail.com>
Co-authored-by: Matt Jibson <matt.jibson@gmail.com>
Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
distsql_indexjoin: this is only a planning test. Modifying thesplit points and queries a bit to make the condition more
restrictive and make the optimizer choose index joins. There was a
single plan that was different, and the difference was minor (the
old planner is emitting an unnecessary column).
distsql_expr: logic-only test, enabling for opt.distsql_scrub: planning test; opt version commented out for now.Release note: None