Skip to content

roachtest: enable periodic heap prof output for kv/splits/nodes=3#26165

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
petermattis:pmattis/roachtest-splits-memprof
May 29, 2018
Merged

roachtest: enable periodic heap prof output for kv/splits/nodes=3#26165
craig[bot] merged 1 commit intocockroachdb:masterfrom
petermattis:pmattis/roachtest-splits-memprof

Conversation

@petermattis
Copy link
Copy Markdown
Collaborator

See #26081

Release note: None

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@petermattis petermattis requested a review from tbg May 29, 2018 14:01
@petermattis
Copy link
Copy Markdown
Collaborator Author

bors r=tschottdorf

@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 29, 2018

Build failed (retrying...)

craig bot pushed a commit that referenced this pull request May 29, 2018
26143: opt: Enable additional logic tests for opt configs r=andy-kimball a=andy-kimball

Enable more logic tests (orms -> snapshot_unrelated_update).
Fix various bugs and issues that were failing tests.


26158: cli: fix `cockroach quit` r=knz a=knz

Informs/fixes #25870.
Fixes  #26144.

This patch fixes the following:

- the logic in `doShutdown()` aims to ignore errors caused by attempts
  connect to a server which is closing its gRPC channels, but was
  missing one case of such errors: during the initial check whether
  the node was running. This patch causes gRPC "closed connection"
  errors to become also ignored in that case.

- previously if there was a transient gRPC error during a hard
  shutdown whereby the shutdown could still succeed, then `cockroach
  quit` would fail no matter what. This patch makes `cockroach quit`
  retry a hard shutdown.

- the warning messages are now emitted on stderr (via `log.Warningf`)
  instead of stdout.

Release note (bug fix): fix a bug where `cockroach quit` would
erroneously fail even though the node already successfully shut down.

Release note (cli change): `cockroach quit` now emits warning message
on its standard error stream, not standard output.

26165: roachtest: enable periodic heap prof output for kv/splits/nodes=3 r=tschottdorf a=petermattis

See #26081

Release note: None

26167: encryption: add cli command `cockroach gen encryption-key` r=windchan7 a=windchan7

Added cli command `cockroach gen encryption-key` to generate store keys for
encryption at rest.

Encryption CLI: #19783.
Release note: None

Co-authored-by: Andrew Kimball <andyk@cockroachlabs.com>
Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Co-authored-by: Peter Mattis <petermattis@gmail.com>
Co-authored-by: Victor Chen <victor@cockroachlabs.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 29, 2018

Build succeeded

@craig craig bot merged commit 68ff1ae into cockroachdb:master May 29, 2018
@petermattis petermattis deleted the pmattis/roachtest-splits-memprof branch May 29, 2018 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants