backport-2.0: storage: ensure non-expired context before each liveness update attempt#25634
Merged
craig[bot] merged 1 commit intocockroachdb:release-2.0from May 22, 2018
Merged
Conversation
Fixes cockroachdb#25430. Before this change, a liveness update could get stuck in an infinite loop if its context expired. This is because it would continue to retry and continue to get `errRetryLiveness` errors due to `AmbiguousResultErrors` created by `DistSender`. Release note: None
Member
|
This change is |
bdarnell
approved these changes
May 17, 2018
Contributor
Author
|
TFTR. bors r+ |
Contributor
Build failed |
Member
|
@nvanbenschoten ping, looks like you might've forgotten that this is still open? |
Contributor
Author
Thanks for the ping! bors r+ |
Contributor
Author
|
Bors failure above was unrelated: |
craig bot
pushed a commit
that referenced
this pull request
May 22, 2018
25634: backport-2.0: storage: ensure non-expired context before each liveness update attempt r=nvanbenschoten a=nvanbenschoten Backport 1/1 commits from #25631. /cc @cockroachdb/release --- Fixes #25430. Before this change, a liveness update could get stuck in an infinite loop if its context expired. This is because it would continue to retry and continue to get `errRetryLiveness` errors due to `AmbiguousResultErrors` created by `DistSender`. Release note: None Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #25631.
/cc @cockroachdb/release
Fixes #25430.
Before this change, a liveness update could get stuck in an infinite
loop if its context expired. This is because it would continue to retry
and continue to get
errRetryLivenesserrors due toAmbiguousResultErrorscreated byDistSender.Release note: None