storage: fix use of context with closed trace#25581
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 16, 2018
Merged
storage: fix use of context with closed trace#25581craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Fixes cockroachdb#25575 Release note: None
Member
|
This change is |
Contributor
|
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 16, 2018
24945: server: exempt healthcheck endpoint from authentication check r=couchand a=vilterp Otherwise, you get the red "connection lost" banner until you log in. This will have no effect until the auth mux is put on the request path (#24944). Fixes #24942 25581: storage: fix use of context with closed trace r=a-robinson a=a-robinson Fixes #25575 Release note: None Co-authored-by: Pete Vilter <vilterp@cockroachlabs.com> Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com>
Contributor
Build succeeded |
mvijaykarthik
pushed a commit
to mvijaykarthik/cockroach
that referenced
this pull request
Sep 25, 2018
Backport 1/1 commits from cockroachdb#25581 --- Fixes cockroachdb#25575 Release note: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25575
Release note: None