storage: put an Aborted txn inside a TxnAbortedError#25539
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 16, 2018
Merged
storage: put an Aborted txn inside a TxnAbortedError#25539craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
TxnAbortedErrors have an updated transaction it them. It makes sense for that transaction to be marked as Aborted, instead of Pending.
Member
|
This change is |
Contributor
|
Review status: 0 of 2 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Contributor
|
This change seems like a good idea, but remember that if you're going to take advantage of it in a future change that you'll need to consider mixed-version clusters that will continue to send pending transactions in this case. |
Contributor
Author
|
ack bors r+ |
Contributor
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
May 16, 2018
25261: storage: harden replica write backpressure mechanism r=nvanbenschoten a=nvanbenschoten Fixes #24215. Fixes #25036. Fixes #24974. Fixes #25141. Fixes #25142. This PR includes a change to harden the replica's write backpressure mechanism. We now reject backpressured write when a range is unsplittable. This is important for placing an upper bound on the size of a range when it consists of just a single row (#24215). The change also fixes a few flaky tests that resulted from backpressure not being restrictive enough. 25539: storage: put an Aborted txn inside a TxnAbortedError r=andreimatei a=andreimatei TxnAbortedErrors have an updated transaction it them. It makes sense for that transaction to be marked as Aborted, instead of Pending. Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com> Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TxnAbortedErrors have an updated transaction it them. It makes sense for
that transaction to be marked as Aborted, instead of Pending.