acceptance: remove Finagle test#25476
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 14, 2018
Merged
Conversation
Fixes cockroachdb#8332. Release note: None
Member
|
This change is |
a-robinson
approved these changes
May 14, 2018
Member
Author
|
TFTR! bors r=a-robinson |
craig bot
pushed a commit
that referenced
this pull request
May 14, 2018
25362: sql: move schema change backfill logic to sql/backfill r=vivekmenezes a=vivekmenezes The distsql backfill calls the sql/backfill code. The future plan is to also call backfill within a transaction that runs schema changes in the same transaction as a CREATE TABLE. Since the CREATE TABLE in a transaction is not visible to other transactions until the transaction commits, the schema change can run the backfill without incrementing the version of the table descriptor. related to #24626 Release note: None 25476: acceptance: remove Finagle test r=a-robinson a=tschottdorf It does do away with the issue #8332, though I'm avoiding the Github keyword to close it to test whether bors will still auto-close the issue due to the mention in the actual commit. Release note: None Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com> Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It does do away with the issue #8332, though I'm avoiding the Github keyword to close it to test whether bors will still auto-close the issue due to the mention in the actual commit.
Release note: None