sql: use a reusable name resolution algo for star expansions#24811
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 16, 2018
Merged
sql: use a reusable name resolution algo for star expansions#24811craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
A previous patch has added a reusable name resolution mechanism which encapsulates all the special cases supported CockroachDB into a single code path. This covers both the resolution of object names and column names. Prior to this patch however, the expansion of qualified stars was using a separate code path. This proved to be incorrect/insufficient however, because one of the special cases of name resolution should apply to star expansion too and the separate code path did not contain the special case. To solve this problem, this patch abstracts the resolution of qualified stars in a common algorithm alongside the others (in `sem/name_resolution.go`) and ensures it is used where applicable. Release note (bug fix): CockroachDB now again allows to use a simply qualified table name in qualified stars (e.g., `SELECT mydb.kv.* FROM kv`), for compatibility with CockroachDB v1.x.
Member
|
This change is |
Contributor
Author
|
@jordanlewis ok to cherry-pick this to 2.0.x? |
Contributor
|
Review status: 0 of 7 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Collaborator
|
Reviewed 7 of 7 files at r1. Comments from Reviewable |
Contributor
Author
|
thanks! |
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 16, 2018
24811: sql: use a reusable name resolution algo for star expansions r=knz a=knz Fixes #24169. A previous patch has added a reusable name resolution mechanism which encapsulates all the special cases supported CockroachDB into a single code path. This covers both the resolution of object names and column names. Prior to this patch however, the expansion of qualified stars was using a separate code path. This proved to be incorrect/insufficient however, because one of the special cases of name resolution should apply to star expansion too and the separate code path did not contain the special case. To solve this problem, this patch abstracts the resolution of qualified stars in a common algorithm alongside the others (in `sem/name_resolution.go`) and ensures it is used where applicable. Release note (bug fix): CockroachDB now again allows to use a simply qualified table name in qualified stars (e.g., `SELECT mydb.kv.* FROM kv`), for compatibility with CockroachDB v1.x. Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Contributor
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Apr 16, 2018
24817: cherrypick-2.0: sql: fix qualified index name resolution r=knz a=knz Picks #24778. cc @cockroachdb/release 24842: cherry-pick 2.0: sql: use a reusable name resolution algo for star expansions r=knz a=knz Picks #24811. cc @cockroachdb/release Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24169.
A previous patch has added a reusable name resolution mechanism which
encapsulates all the special cases supported CockroachDB into a single
code path. This covers both the resolution of object names and column
names.
Prior to this patch however, the expansion of qualified stars was
using a separate code path. This proved to be incorrect/insufficient
however, because one of the special cases of name resolution should
apply to star expansion too and the separate code path did not contain
the special case.
To solve this problem, this patch abstracts the resolution of
qualified stars in a common algorithm alongside the others (in
sem/name_resolution.go) and ensures it is used where applicable.Release note (bug fix): CockroachDB now again allows to use a simply
qualified table name in qualified stars (e.g.,
SELECT mydb.kv.* FROM kv), for compatibility with CockroachDB v1.x.