sql: clarify the error message upon access to vtable with no db#24772
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 15, 2018
Merged
sql: clarify the error message upon access to vtable with no db#24772craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Prior to this patch: ``` root@:26257/> select * from pg_catalog.pg_class; pq: no database specified ``` After: ``` root@:26257/> select * from pg_catalog.pg_class; pq: cannot access virtual schema in anonymous database HINT: verify that the current database is set ``` Release note (sql change): the error message produced upon accessing a virtual schema with no database prefix (e.g. when `database` is not set) is now clarified.
Member
|
This change is |
Contributor
Author
|
@jordanlewis should we cherry-pick this to 2.0.x? |
jordanlewis
reviewed
Apr 13, 2018
|
|
||
| var errInvalidDbPrefix = pgerror.NewError(pgerror.CodeUndefinedObjectError, | ||
| "cannot access virtual schema in anonymous database", | ||
| ).SetHintf("verify that the current database is set") |
Member
There was a problem hiding this comment.
nit: is there a SetHint without the f?
jordanlewis
approved these changes
Apr 13, 2018
Member
|
This seems cherrypickable. |
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 15, 2018
24772: sql: clarify the error message upon access to vtable with no db r=knz a=knz Fixes #23958. Prior to this patch: ``` root@:26257/> select * from pg_catalog.pg_class; pq: no database specified ``` After: ``` root@:26257/> select * from pg_catalog.pg_class; pq: cannot access virtual schema in anonymous database HINT: verify that the current database is set ``` Release note (sql change): the error message produced upon accessing a virtual schema with no database prefix (e.g. when `database` is not set) is now clarified. Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23958.
Prior to this patch:
After:
Release note (sql change): the error message produced upon accessing a
virtual schema with no database prefix (e.g. when
databaseis notset) is now clarified.