Skip to content

cli: refactor dump tests to use datadriven#24653

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
madelynnblue:dump
Apr 12, 2018
Merged

cli: refactor dump tests to use datadriven#24653
craig[bot] merged 1 commit intocockroachdb:masterfrom
madelynnblue:dump

Conversation

@madelynnblue
Copy link
Copy Markdown
Contributor

Idea from @justinj.

Closes #22403

Release note: None

@madelynnblue madelynnblue requested a review from justinj April 11, 2018 05:18
@madelynnblue madelynnblue requested a review from a team as a code owner April 11, 2018 05:18
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@justinj justinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it, LGTM

INSERT INTO g (x, y) VALUES
(3, 4);
----
---- No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no newline at end

@madelynnblue
Copy link
Copy Markdown
Contributor Author

bors r+

Idea from @justinj.

Closes #22403

Release note: None
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 11, 2018

Canceled

@madelynnblue
Copy link
Copy Markdown
Contributor Author

bors r+

craig bot pushed a commit that referenced this pull request Apr 12, 2018
24653: cli: refactor dump tests to use datadriven r=mjibson a=mjibson

Idea from @justinj.

Closes #22403

Release note: None

Co-authored-by: Matt Jibson <matt.jibson@gmail.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 12, 2018

Build succeeded

@craig craig bot merged commit 418bf90 into cockroachdb:master Apr 12, 2018
@madelynnblue madelynnblue deleted the dump branch April 18, 2018 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants