remove all metadata related#2426
Closed
il9ue wants to merge 2 commits intocockroachdb:masterfrom
il9ue:il9ue-patch-1
Closed
remove all metadata related#2426il9ue wants to merge 2 commits intocockroachdb:masterfrom il9ue:il9ue-patch-1
il9ue wants to merge 2 commits intocockroachdb:masterfrom
il9ue:il9ue-patch-1
Conversation
based on the comments about MakeRangeIDKey, added the remove all metadata involved with it. added the function to check any errors while deleting metadata.
|
ilque seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account (for further information, click here). |
Contributor
Contributor
There was a problem hiding this comment.
there is a lot of duplication here, which you can eliminate using a slice of anonymous structs:
now := s.Clock().Now()
metadata := []struct{
name string
key proto.Key
}{
{"cache", keys.ResponseCacheKey(rangeID, nil)},
{"logprefix", keys.RaftLogPrefix(rangeID)},
{"hardstate", keys.RaftHardStateKey(rangeID)},
...
}
for _, metadatum := range metadata {
if err := engine.MVCCDelete(s.engine, nil, metadatum.key, now, nil); err != nil {
return util.Errorf("cannot delete %s key %s: %s", metadatum.name, metadatum.key, err)
}
}
Contributor
There was a problem hiding this comment.
Rather than enumerating all of these things, I think we could just construct a prefix that matches all RangeIDKeys.
Contributor
|
This also needs tests. |
Contributor
There was a problem hiding this comment.
MVCCDelete deletes a single value but RaftLogPrefix identifies a range. This needs to use MVCCDeleteRange.
Contributor
|
Closing in favour #2395. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on the comments about MakeRangeIDKey, added the remove all metadata involved with it. added the function to check any errors while deleting metadata.