store.go merge range metadata cleanup after remove replica#2395
Closed
il9ue wants to merge 12 commits intocockroachdb:masterfrom
il9ue:master
Closed
store.go merge range metadata cleanup after remove replica#2395il9ue wants to merge 12 commits intocockroachdb:masterfrom il9ue:master
il9ue wants to merge 12 commits intocockroachdb:masterfrom
il9ue:master
Conversation
|
ilque seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account (for further information, click here). |
storage/store.go
Outdated
Contributor
There was a problem hiding this comment.
Metadata is more than just the range descriptor: it's also all the raft state and other stats. Basically, everything that calls MakeRangeIDKey in
Line 62 in 1988fb1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on code comment, try to check if there are remained metadata after remove replica on mergeRange function.