add pre-commit hook & convenience script to add it. fix some vet errors.#2
add pre-commit hook & convenience script to add it. fix some vet errors.#2spencerkimball merged 2 commits intocockroachdb:masterfrom andybons:andybons_govet
Conversation
githooks/pre-commit
Outdated
There was a problem hiding this comment.
nit set -x as well for diagnostic output
|
LG with a few comments and go questions |
|
Updated. |
|
LG |
add pre-commit hook & convenience script to add it. fix some vet errors.
Specialcase placeholders in casts during the first pass.
…e-flow bulkmerge: create distsql plan
The bug caused change replicas operations never to be marked as complete in the `Controller`, causing the mma store rebalancers to stall after their first change replicas. Epic: none Release note: None
The bug caused change replicas operations never to be marked as complete in the `Controller`, causing the mma store rebalancers to stall after their first change replicas. Epic: none Release note: None
When a cluster's logs contain a raft panic, it will be extended (by a week), volume snapshots will be taken, and the cluster will not be destroyed. This gives us the artifacts for a thorough investigation. Verified manually via: ``` run --local acceptance/invariant-check-detection/failed=true ``` Here is the (editorialized) output: ``` test-teardown: 2025/05/20 08:15:15 cluster.go:2559: running cmd `([ -d logs ] && grep -RE '^...` on nodes [:1-4]; details in run_081515.744363000_n1-4_d-logs-grep-RE-Fraft.log test-teardown: 2025/05/20 08:15:16 cluster.go:2995: extending cluster by 168h0m0s test-teardown: 2025/05/20 08:15:16 cluster.go:1104: saving cluster local [tag:] (4 nodes) for debugging (--debug specified) test-teardown: 2025/05/20 08:15:16 test_impl.go:478: test failure #2: full stack retained in failure_2.log: (test_runner.go:1705).maybeSaveClusterDueToInvariantProblems: invariant problem - snap name invariant-problem-local-8897676895823393049: logs/foo.log:F250502 11:37:20.387424 1036 raft/raft.go:2411 ⋮ [T1,Vsystem,n1,s1,r155/1:?/Table/113/1/{43/578…-51/201…}?] 80 match(30115) is out of range [lastIndex(30114)]. Was the raft log corrupted, truncated, or lost? ``` Closes #145953. Informs #146617. Informs #138028. Epic: none
146990: roachtest: unconditionally save clusters that show raft fatal errors r=tbg a=tbg When a cluster's logs contain a raft panic, it will be extended (by a week), volume snapshots will be taken, and the cluster will not be destroyed. This gives us the artifacts for a thorough investigation. Verified manually via: ``` run --local acceptance/invariant-check-detection/failed=true ``` Here is the (editorialized) output: ``` test-teardown: 2025/05/20 08:15:15 cluster.go:2559: running cmd `([ -d logs ] && grep -RE '^...` on nodes [:1-4]; details in run_081515.744363000_n1-4_d-logs-grep-RE-Fraft.log test-teardown: 2025/05/20 08:15:16 cluster.go:2995: extending cluster by 168h0m0s test-teardown: 2025/05/20 08:15:16 cluster.go:1104: saving cluster local [tag:] (4 nodes) for debugging (--debug specified) test-teardown: 2025/05/20 08:15:16 test_impl.go:478: test failure #2: full stack retained in failure_2.log: (test_runner.go:1705).maybeSaveClusterDueToInvariantProblems: invariant problem - snap name invariant-problem-local-8897676895823393049: logs/foo.log:F250502 11:37:20.387424 1036 raft/raft.go:2411 ⋮ [T1,Vsystem,n1,s1,r155/1:?/Table/113/1/{43/578…-51/201…}?] 80 match(30115) is out of range [lastIndex(30114)]. Was the raft log corrupted, truncated, or lost? ``` Closes #145953. Informs #146617. Informs #138028. Fixes #146355. Epic: none 147683: pkg/util/log: parse otlp sink from yaml config r=TheComputerM a=TheComputerM OpenTelemetry is now an industry standard for o11y and is more efficient than other log sinks currently available. This commit only defines basic configuration options for the OTLP sink, like address, insecure, and compression, and adds logic to parse them from the YAML config. The actual sink implementation will follow in a future commit. Informs: #143049 Release note: None Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com> Co-authored-by: Mudit Somani <mudit.somani@cockroachlabs.com>
The bug caused change replicas operations never to be marked as complete in the `Controller`, causing the mma store rebalancers to stall after their first change replicas. Epic: none Release note: None
|
Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link) |
|
Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link) |
|
Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link) |
|
Detected infrastructure failure (matched: self-hosted runner lost communication with the server, self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link) |
The precommit will run
Within the cockroach dir, just run the initrepo.sh script and it will be enabled for you.