Return (response, error) #4#1729
Merged
tamird merged 2 commits intocockroachdb:masterfrom Jul 19, 2015
tamird:return-replies-4
Merged
Return (response, error) #4#1729tamird merged 2 commits intocockroachdb:masterfrom tamird:return-replies-4
tamird merged 2 commits intocockroachdb:masterfrom
tamird:return-replies-4
Conversation
Closed
Collaborator
There was a problem hiding this comment.
If you used := here, go vet (without --shadow) should give a warning about err declared but not used.
Collaborator
There was a problem hiding this comment.
Oh, maybe this wasn't what you were pointing to?
Contributor
Author
There was a problem hiding this comment.
Ah, I pointed to the wrong place. It was actually here https://github.com/cockroachdb/cockroach/pull/1729/files#diff-dae9f8a58ca2ec436440b12989c1982dR1253
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on this PR I discovered that shadowing
erris a serious footgun, so I'm going to suggest that we tighten up our linters to prevent that. I've started working on that already, and it results in some annoying contortions, but the sad reality is that shadowingerris quite a dangerous pattern.Anyway, the next PR in this series will require changing
Sender, so I expect it'll be bigger than the past few have been. Apologies in advance.