thanks for tracking these down, just had small questions

@rafiss made 3 comments.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @DarrylWong, @fqazi, and @nameisbhaskar).

pkg/sql/paramparse/paramparse.go line 43 at r1 (raw file):

	switch v := eval.UnwrapDatum(ctx, evalCtx, val).(type) {
	case *tree.DString:
		val, err := strconv.ParseFloat(string(*v), 64)

i fixed a few of these here too: #161472

let's make this error consistent:

if err != nil {
  return 0, pgerrors.Wrapf(pgcode.InvalidParameterValue, err, "error decoding %q", name)
}

also, do you know why #161472 was not sufficient? can you add a basic logictest showing what wasn't being handled before?

pkg/workload/schemachange/operation_generator.go line 3742 at r2 (raw file):

      FROM information_schema.columns
		 WHERE table_name SIMILAR TO 'table_w[0-9]_+%%' AND column_name <> 'rowid'
		       AND column_name NOT LIKE 'crdb_internal%%%%'

why do we need %%%%? it seems like the %% before may have been a mistake

@fqazi made 2 comments.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @DarrylWong, @nameisbhaskar, and @rafiss).

pkg/workload/schemachange/operation_generator.go line 3742 at r2 (raw file):

Done.

pkg/sql/paramparse/paramparse.go line 43 at r1 (raw file):

I backed this part out, and it was because I was on a stale master 🤦 .

@fqazi made 1 comment.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @DarrylWong, @nameisbhaskar, and @rafiss).

pkg/sql/paramparse/paramparse.go line 43 at r1 (raw file):

We only need to handle the mixed version case

@rafiss reviewed 1 file and made 1 comment.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong and @nameisbhaskar).