storageparam: return proper pgcode for float parsing errors#161472
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 21, 2026
Merged
storageparam: return proper pgcode for float parsing errors#161472craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Previously, when storage parameters like `fillfactor`, `geometry_min_x`, or `sql_stats_automatic_collection_fraction_stale_rows` received an invalid string value, the error returned had an internal error code (XXUUU) because the raw `strconv.ParseFloat` error was propagated without wrapping. This change wraps these errors with `pgerror.Wrapf` using `pgcode.InvalidParameterValue` (22023) to provide a proper user-facing error code. Fixes cockroachdb#160814 Release note: None
209ea8b to
a3ff990
Compare
Collaborator
Author
|
tftr! bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when storage parameters like
fillfactor,geometry_min_x, orsql_stats_automatic_collection_fraction_stale_rowsreceived an invalid string value, the error returned had an internal error code (XXUUU) because the rawstrconv.ParseFloaterror was propagated without wrapping.This change wraps these errors with
pgerror.Wrapfusingpgcode.InvalidParameterValue(22023) to provide a proper user-facing error code.Fixes #161364
Fixes #154926
Release note: None