schemachange: fix recent flake in TestWorkload#160842
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 10, 2026
Merged
schemachange: fix recent flake in TestWorkload#160842craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
7ae09c9 to
4a969b9
Compare
Member
Author
|
Thanks Wenyi! |
Member
Author
|
bors r- I'm currently stressing the test and need to add at least one more error code for INVALID_VAL |
Contributor
|
Canceled. |
Recently merged in ad868ab extension to the test is flaky - fix up a couple of minor bugs. Release note: None
4a969b9 to
7069ae8
Compare
Member
Author
|
Ok, I think we're good. bors r+ |
fqazi
approved these changes
Jan 10, 2026
Collaborator
fqazi
left a comment
There was a problem hiding this comment.
@fqazi reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @golgeek, @shghasemi, and @srosenberg).
craig bot
pushed a commit
that referenced
this pull request
Jan 10, 2026
160632: sql/bulkmerge: reuse SST iterator across bulk merge tasks r=spilchen a=spilchen This change reduces overhead in the bulk merge processor by initializing a single iterator over all input SSTs at startup, rather than creating a new one per task. The iterator is reused across tasks, seeking only when needed. Informs #159414 Epic: CRDB-48845 Release note: none Co-authored by: `@jeffswenson` 160842: schemachange: fix recent flake in TestWorkload r=yuzefovich a=yuzefovich Recently merged in ad868ab extension to the test is flaky - fix up a couple of minor bugs. Fixes: #160814. Release note: None Co-authored-by: Matt Spilchen <matt.spilchen@cockroachlabs.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently merged in ad868ab extension to the test is flaky - fix up a couple of minor bugs.
Fixes: #160814.
Release note: None