schemachanger: unskip multitenancy tests for TestCreateObjectConcurrency#160592
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 7, 2026
Merged
Conversation
Under multitenancy, the test can encounter retry errors while the schema changer updates the span_counts table. This change wraps the test logic in SucceedsWithin with a longer timeout (10s for tenant mode vs 1s otherwise) and moves database setup into the retry loop. Release note: None
Member
|
This change is |
fqazi
approved these changes
Jan 7, 2026
Collaborator
fqazi
left a comment
There was a problem hiding this comment.
@fqazi reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss).
Collaborator
Author
|
bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under multitenancy, the test can encounter retry errors while the schema changer updates the span_counts table. This change wraps the test logic in SucceedsWithin with a longer timeout (10s for tenant mode vs 1s otherwise) and moves database setup into the retry loop.
fixes #138733
Release note: None