colfetcher: emit periodic query progress update metadata#158029
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 10, 2026
Merged
colfetcher: emit periodic query progress update metadata#158029craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
f61e2b2 to
46aea22
Compare
e5a8520 to
cb55134
Compare
cb55134 to
1490901
Compare
This commit extends the query progress reporting that we do in the row-by-row tableReader to the vectorized scan operators too. Namely, after about 20k rows have been output, we'll emit the RowsRead metadata that we then use in DistSQLReceiver to update progressAtomic. Then the result shows up in `phase` column of SHOW QUERIES. Release note (sql change): Queries executed via the vectorized engine now display their progress in `phase` column of SHOW QUERIES. Previously, this feature was only available in the row-by-row engine.
1490901 to
be77931
Compare
DrewKimball
approved these changes
Jan 10, 2026
Collaborator
DrewKimball
left a comment
There was a problem hiding this comment.
@DrewKimball reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich).
Member
Author
|
Thanks for the quick review! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jan 10, 2026
158029: colfetcher: emit periodic query progress update metadata r=yuzefovich a=yuzefovich This commit extends the query progress reporting that we do in the row-by-row tableReader to the vectorized scan operators too. Namely, after about 20k rows have been output, we'll emit the RowsRead metadata that we then use in DistSQLReceiver to update progressAtomic. Then the result shows up in `phase` column of SHOW QUERIES. Fixes: #26639. Release note (sql change): Queries executed via the vectorized engine now display their progress in `phase` column of SHOW QUERIES. Previously, this feature was only available in the row-by-row engine. Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Contributor
|
Build failed: |
Member
Author
|
bors retry |
craig bot
pushed a commit
that referenced
this pull request
Jan 10, 2026
158029: colfetcher: emit periodic query progress update metadata r=yuzefovich a=yuzefovich This commit extends the query progress reporting that we do in the row-by-row tableReader to the vectorized scan operators too. Namely, after about 20k rows have been output, we'll emit the RowsRead metadata that we then use in DistSQLReceiver to update progressAtomic. Then the result shows up in `phase` column of SHOW QUERIES. Fixes: #26639. Release note (sql change): Queries executed via the vectorized engine now display their progress in `phase` column of SHOW QUERIES. Previously, this feature was only available in the row-by-row engine. Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Contributor
|
Build failed: |
Member
Author
|
bors retry |
craig bot
pushed a commit
that referenced
this pull request
Jan 10, 2026
158029: colfetcher: emit periodic query progress update metadata r=yuzefovich a=yuzefovich This commit extends the query progress reporting that we do in the row-by-row tableReader to the vectorized scan operators too. Namely, after about 20k rows have been output, we'll emit the RowsRead metadata that we then use in DistSQLReceiver to update progressAtomic. Then the result shows up in `phase` column of SHOW QUERIES. Fixes: #26639. Release note (sql change): Queries executed via the vectorized engine now display their progress in `phase` column of SHOW QUERIES. Previously, this feature was only available in the row-by-row engine. 160632: sql/bulkmerge: reuse SST iterator across bulk merge tasks r=spilchen a=spilchen This change reduces overhead in the bulk merge processor by initializing a single iterator over all input SSTs at startup, rather than creating a new one per task. The iterator is reused across tasks, seeking only when needed. Informs #159414 Epic: CRDB-48845 Release note: none Co-authored by: `@jeffswenson` Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: Matt Spilchen <matt.spilchen@cockroachlabs.com>
Contributor
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Jan 10, 2026
158029: colfetcher: emit periodic query progress update metadata r=yuzefovich a=yuzefovich This commit extends the query progress reporting that we do in the row-by-row tableReader to the vectorized scan operators too. Namely, after about 20k rows have been output, we'll emit the RowsRead metadata that we then use in DistSQLReceiver to update progressAtomic. Then the result shows up in `phase` column of SHOW QUERIES. Fixes: #26639. Release note (sql change): Queries executed via the vectorized engine now display their progress in `phase` column of SHOW QUERIES. Previously, this feature was only available in the row-by-row engine. Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Contributor
|
Build failed: |
Member
Author
|
bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit extends the query progress reporting that we do in the row-by-row tableReader to the vectorized scan operators too. Namely, after about 20k rows have been output, we'll emit the RowsRead metadata that we then use in DistSQLReceiver to update progressAtomic. Then the result shows up in
phasecolumn of SHOW QUERIES.Fixes: #26639.
Release note (sql change): Queries executed via the vectorized engine now display their progress in
phasecolumn of SHOW QUERIES. Previously, this feature was only available in the row-by-row engine.