Skip to content

rangefeed: add assertion that OnError is called on disconnected registration#155616

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
stevendanna:ssd/add-assertion
Oct 22, 2025
Merged

rangefeed: add assertion that OnError is called on disconnected registration#155616
craig[bot] merged 1 commit intocockroachdb:masterfrom
stevendanna:ssd/add-assertion

Conversation

@stevendanna
Copy link
Copy Markdown
Collaborator

Epic: none
Release note: None

@stevendanna stevendanna requested a review from a team as a code owner October 17, 2025 14:40
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Oct 17, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@stevendanna stevendanna requested a review from wenyihu6 October 17, 2025 14:43
@stevendanna
Copy link
Copy Markdown
Collaborator Author

bors r+

craig bot pushed a commit that referenced this pull request Oct 22, 2025
155616: rangefeed: add assertion that OnError is called on disconnected registration r=stevendanna a=stevendanna

Epic: none
Release note: None

155797: *: replace some usages of global rand r=yuzefovich a=yuzefovich

**sem/builtins: use RNG from eval context for 'st_generatepoints'**

***: replace some usages of global rand**

When we use `rand.*` methods like `math/rand.Intn`, under the hood we hit
the global rand source, which is protected by a mutex, so we could be subject
to contention on that lock. This commit updates some of such usages in
favor of object-specific rand source to avoid that. Note that allocating
a separate rand source is not free (the allocation itself is about 5KiB
in size), so we modify spots where the lifecycle matches that of the
server or when the affected code is heavy already / not on the hot path
(also when it's clear that the access is from within a single
goroutine).

Epic: None
Release note: None

155861: kvserver: deflake TestPromoteNonVoterInAddVoter r=arulajmani a=arulajmani

This test could previously fail because a lease transfer could race with a split. Without the split, the effects of the span config (that the test asserts on) will not apply. We sidestep this problem by removing the need of a split entirely -- by tuning some cluster settings to ensure that every table is on its own range to begin with.

H/t to `@pav-kv` for the analysis on this one.

Closes #155828 
Closes #155747 
Closes #155316 
Closes #154773 
Closes #134383

Release note: None

Co-authored-by: Steven Danna <danna@cockroachlabs.com>
Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Co-authored-by: Arul Ajmani <arulajmani@gmail.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Oct 22, 2025

Build failed (retrying...):

@craig craig bot merged commit 5e07f09 into cockroachdb:master Oct 22, 2025
24 checks passed
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Oct 22, 2025

rishabh7m added a commit to crltest-issue-syncing/cockroach-fork that referenced this pull request Nov 20, 2025
rishabh7m added a commit to crltest-issue-syncing/cockroach-fork that referenced this pull request Nov 21, 2025
rishabh7m added a commit to crltest-issue-syncing/cockroach-fork that referenced this pull request Nov 21, 2025
rishabh7m added a commit to crltest-issue-syncing/cockroach-fork that referenced this pull request Dec 1, 2025
rishabh7m added a commit to crltest-issue-syncing/cockroach-fork that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants