workload/schemachange: expect DatatypeMismatch errors for NULL defaults#153039
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 8, 2025
Conversation
Previously, the workload only expected DatatypeMismatch errors when setting default values that were non-NULL. However, after fixing the type casting syntax in SET DEFAULT operations, NULL values with explicit type casts (e.g., NULL::enum_type) now properly reach the type checker and correctly produce DatatypeMismatch errors when the cast type doesn't match the column type. Fixes cockroachdb#152957 Release note: none Epic: None
Member
|
This change is |
fqazi
approved these changes
Sep 5, 2025
Collaborator
fqazi
left a comment
There was a problem hiding this comment.
@fqazi reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @golgeek and @herkolategan)
Contributor
Author
|
TFTR! bors r+ |
Contributor
msbutler
pushed a commit
to msbutler/cockroach
that referenced
this pull request
Sep 12, 2025
153039: workload/schemachange: expect DatatypeMismatch errors for NULL defaults r=spilchen a=spilchen Previously, the workload only expected DatatypeMismatch errors when setting default values that were non-NULL. However, after fixing the type casting syntax in SET DEFAULT operations, NULL values with explicit type casts (e.g., NULL::enum_type) now properly reach the type checker and correctly produce DatatypeMismatch errors when the cast type doesn't match the column type. Fixes cockroachdb#152957 Release note: none Epic: None Co-authored-by: Matt Spilchen <matt.spilchen@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the workload only expected DatatypeMismatch errors when setting default values that were non-NULL. However, after fixing the type casting syntax in SET DEFAULT operations, NULL values with explicit type casts (e.g., NULL::enum_type) now properly reach the type checker and correctly produce DatatypeMismatch errors when the cast type doesn't match the column type.
Fixes #152957
Release note: none
Epic: None