storage: Remove the last vestiges of non-proposer-evaluated-KV#15228
storage: Remove the last vestiges of non-proposer-evaluated-KV#15228bdarnell merged 2 commits intocockroachdb:masterfrom
Conversation
|
Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. pkg/storage/replica.go, line 3655 at r1 (raw file):
I wonder if this should be more verbose and mention what action the user should take or point to this week's beta release notes. Comments from Reviewable |
358cc9c to
bd03a7e
Compare
|
Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion. pkg/storage/replica.go, line 3655 at r1 (raw file): Previously, petermattis (Peter Mattis) wrote…
Done. Comments from Reviewable |
|
Reviewed 3 of 3 files at r1, 1 of 1 files at r2. pkg/storage/track_raft_protos.go, line 46 at r1 (raw file):
"consistency" Comments from Reviewable |
bd03a7e to
c400022
Compare
|
Reviewed 1 of 1 files at r3. Comments from Reviewable |
|
I think you caught some build skew related to my rocksdb patch here, can you rebase for good measure? |
c400022 to
ae805c4
Compare
|
And now it's (correctly) failing the reference binary acceptance tests. It's time to bump up the version used there. |
Remove test data for cockroachdb/cockroach#7429 because we no longer support upgrading from that version. See cockroachdb/cockroach#15228
Remove test data for cockroachdb/cockroach#7429 because we no longer support upgrading from that version. See cockroachdb/cockroach#15228
|
Added a new commit to update the acceptance tests (it won't pass until cockroachdb/postgres-test#22 is merged and tagged). |
The propEvalKV rollout means we can no longer support upgrading from versions older than 20170413. Update tests and remove some no-longer-needed migrations.
This allows us to remove nearly all protobufs from the "below raft" list of types requiring strict compatibility.
ffe1a0c to
8871d35
Compare
|
Done, and I also swapped the order of the commits so the acceptance tests pass for both of them. |
|
LGTM! |
This allows us to remove nearly all protobufs from the "below raft"
list of types requiring strict compatibility.