Skip to content

sqlproxyccl: improve authentication throttle error#117554

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
jeffswenson:jeffswenson-improve-throttle-error
Jan 10, 2024
Merged

sqlproxyccl: improve authentication throttle error#117554
craig[bot] merged 1 commit intocockroachdb:masterfrom
jeffswenson:jeffswenson-improve-throttle-error

Conversation

@jeffswenson
Copy link
Copy Markdown
Collaborator

The sql proxy will throttle connection attempts if a (client IP, tenant cluster) pair has too many authentication failures. The error is usually caused by a misconfigured password in a connection pool. This change replaces the "connection attempt throttled" error message with "too many failed authentication attempts". There is a hint that includes this message but not all drivers are configured to log hints.

Fixes #117552

The sql proxy will throttle connection attempts if a (client IP, tenant
cluster) pair has too many authentication failures. The error is usually
caused by a misconfigured password in a connection pool. This change
replaces the "connection attempt throttled" error message with "too many
failed authentication attempts". There is a hint that includes this
message but not all drivers are configured to log hints.

Fixes cockroachdb#117552
@jeffswenson jeffswenson requested a review from a team January 9, 2024 16:39
@jeffswenson jeffswenson requested review from a team as code owners January 9, 2024 16:39
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@jeffswenson jeffswenson added the backport-23.2.x PAST MAINTENANCE SUPPORT: 23.2 patch releases via ER request only label Jan 9, 2024
@jeffswenson
Copy link
Copy Markdown
Collaborator Author

Thanks for the review!

@jeffswenson
Copy link
Copy Markdown
Collaborator Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 9, 2024

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 9, 2024

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 10, 2024

This PR was included in a batch that timed out, it will be automatically retried

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 10, 2024

Build succeeded:

@craig craig bot merged commit 05d1395 into cockroachdb:master Jan 10, 2024
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Jan 10, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-23.2-117554 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/117594/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-23.2.x PAST MAINTENANCE SUPPORT: 23.2 patch releases via ER request only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sqlproxy: improve authentication throttle error

3 participants