roachtest: port change-replicas/mixed-version to mixedversion#113222
roachtest: port change-replicas/mixed-version to mixedversion#113222craig[bot] merged 3 commits intocockroachdb:masterfrom
change-replicas/mixed-version to mixedversion#113222Conversation
|
This change is |
change-replicas/mixed-version to mixedversion
|
A minor annoyance here is the guidance to return errors from steps. It's usually much more convenient to use Testify (e.g. |
renatolabs
left a comment
There was a problem hiding this comment.
Nice, thanks for adding the cluster setting option!
A minor annoyance here is the guidance to return errors from steps.
Yeah, I somewhat regret this direction. It is something I want to revisit when I get the chance.
One comment about the change-replicas test: instead of picking a random gateway in the beginning of the test and using it all the time, you could change your db.ExecContext calls to h.Exec. That should take care of: 1) picking a random node each time; 2) logging the statement executed; 3) calling ExecContext with the appropriate context.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @srosenberg)
8c7eca1 to
ecfbfcb
Compare
Good idea, done. Seeing some test flakes here where the replicate queue fails to enforce zone configs. The previous test had workarounds for this, but I was hoping these wouldn't be necessary anymore -- will have a closer look. |
|
The flakes here appear to be because the nodes sometimes get incorrect node attributes. E.g. n3 has attribute Opened #113384 for this. |
ecfbfcb to
b800480
Compare
This allows e.g. passing envvars to clusters. Epic: none Release note: None
Epic: none Release note: None
Epic: none Release note: None
b800480 to
c275c93
Compare
|
Merging now that #113384 is resolved. Thanks for the fix and review! bors r+ |
|
Build succeeded: |
|
blathers backport 23.1 |
roachtestutil/mixedversion: add
ClusterSettingOptionThis allows e.g. passing envvars to clusters.
roachtest: port
change-replicas/mixed-versiontomixedversionResolves #110532.
Epic: none
Release note: None