113063: workload/schemachange: add Generate helper r=Xiang-Gu a=chrisseto #### bdb4617 workload/schemachange: add Generate helper Previously, workload/schemachange operation generators were bespoke implements per DDL. This added a high degree of effort towards adding new DDL. Maintaining or debugging previously added DDLs could also be quite difficult. One of the primary difficulties was calling out the various forms a DDL could take and then randomly opting for one. This was due to having a mixture of valid and invalid cases and, at times, impossible cases. This commit implements a text/template based helper `Generate` for aiding the development and maintenance of operation generators. Epic: CRDB-19168 Release note: None 113222: roachtest: port `change-replicas/mixed-version` to `mixedversion` r=erikgrinaker a=erikgrinaker **roachtestutil/mixedversion: add `ClusterSettingOption`** This allows e.g. passing envvars to clusters. **roachtest: port `change-replicas/mixed-version` to `mixedversion`** Resolves #110532. Epic: none Release note: None 113382: upgrademanager: defer retrieval of cluster ID r=adityamaru a=stevendanna Previously, the upgrade manager's constructor took the cluster ID directly. However, the cluster ID may not be initialised at the point of constructing the manager. This isn't typically a problem because in most cases, the only upgrade that _require_ the cluster ID doesn't actually take the cluster ID from the manager. Rather, it gets the cluster ID from the execution context of the migration job on resumption. But, tests such as TestRetriesWithExponentialBackoff set the DontUseJobs testing hook. In this case, the migration manager runs the upgrades directly, passing its own copy of the cluster ID, which is unitialized. To fix this, we pass the cluster ID container rather than the cluster ID so that we can defer retrieving it until we actually run the migrations, at which point it should be set. Informs #112763 Release note: none Co-authored-by: Chris Seto <chriskseto@gmail.com> Co-authored-by: Erik Grinaker <grinaker@cockroachlabs.com> Co-authored-by: Steven Danna <danna@cockroachlabs.com>

roachtest: port change-replicas/mixed-version to new mixed-version framework #110532

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions