sqlstats: fix counter for in-memory fingerprints#111613
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 3, 2023
j82w:111583
Merged
sqlstats: fix counter for in-memory fingerprints#111613craig[bot] merged 1 commit intocockroachdb:masterfrom j82w:111583
craig[bot] merged 1 commit intocockroachdb:masterfrom
j82w:111583
Conversation
Member
|
This change is |
maryliag
approved these changes
Oct 2, 2023
Contributor
maryliag
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @j82w)
Problem: The counters used to track the number of unique fingerprints we store in-memory for sql stats were refactored in #110805. In change #110805 a bug was introduced where it incresease the memory instead of resetting the counts. This causes the statstics to stop calculating new stats once the limit is hit. Solution: Fix the bug by resetting the counters instead of increasing them. Added new test to test the reset functionality. Fixes: #111583 Release note (sql change): Fix a bug that causes the sql stats to stop collecting new stats.
Contributor
Author
|
bors r+ |
Contributor
|
Build failed: |
Contributor
Author
|
bors retry |
Contributor
|
Build failed: |
Contributor
Author
|
bors retry |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The counters used to track the number of unique fingerprints we store in-memory for sql stats were refactored in #110805. In change #110805 a bug was introduced where it incresease the memory instead of resetting the counts. This causes the statstics to stop calculating new stats once the limit is hit.
Solution:
Fix the bug by resetting the counters instead of increasing them. Added new test to test the reset functionality.
Fixes: #111583
Release note (sql change): Fix a bug that causes the sql stats to stop collecting new stats.