Skip to content

sqlstats: counters for in-memory fingerprints never reset #111583

@xinhaoz

Description

@xinhaoz

The counters used to track the number of unique fingerprints we store in-memory for sql stats were refactored in #110805. In this change, we erronneously doubled the number of in-memory fingerprints tracked by the counter when we were supposed to reset the values - https://github.com/cockroachdb/cockroach/pull/110805/files#diff-eb9d7df12ea768da5a41031449150b2473270b047efd8a191dca9a38516dd580L676.

What this causes:

  • Once the doubling hits the limit setting we are constantly returning ErrFingerprintLimitReached which signals a flush to occur
  • Due to above, flushes are being triggered aggressively once we encounter this
  • Once we erronneously hit the max fingerprint limit, since we never successfully reset the counter we can not record new stats in the application container

Jira issue: CRDB-31976

Metadata

Metadata

Assignees

Labels

A-cluster-observabilityRelated to cluster observabilityC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.branch-release-23.1Used to mark GA and release blockers, technical advisories, and bugs for 23.1release-blockerIndicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.v23.1.12

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions